Implement enough of SEXP, RDSReader, and Compiler to pass tests
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SEXP subclasses beyond those of specific types + normalized creating SEXPs by putting all constructors in the SEXP class
…ully implemented)
…piled test prints something sane
Jakobeha
force-pushed
the
sexp-rds-compiler-init
branch
from
39363e9 to
022ba4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored in the code from filip's branch, and then implemented enough of it so the
.rdsreader and bytecode compiler tests passed.I don't know if what the compiler creates the correct bytecode because it only prints the result. Also it seems that whenever I try to save a list to RDS, it gets loaded as a vector with
names, even though R loads it back as a list; I'm not sure if we're supposed to do that too.Some types of SEXPs aren't defined, and probably SEXPs to deserialize instructions to compile need to be implemented.