Suppress pmd's UnusedImport and UnnecessaryParens and allow pushing without PMD's approval
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can see if something fails static analyses but passes tests, in case we want to resolve them later
There are still a couple warnings: - A couple null checks which are immediately apparent but VSCode can't decide. If this is an issue, we should disable null analysis entirely on VSCode. - "The hierarchy of type X is inconsistent" but it compiles fine. This seems to be an Eclipse/VSCode issue and I think the only way to resolve is to simplify inheritance, but idk if it's worth it since this only shows up in analysis. Also, VSCode seems to change the non-null settings on startup which caused the warnings to pop-up again before. I also changed VSCode settings, so if this happens, it will simply disable all null-checks instead of breaking them. So, maybe we'll just disable null analysis entirely on VSCode...
…ter doesn't generate an artifact unlike `verify`
|
Also, I tried to fix null-checks in VSCode. And there's a way to temporarily make them work by changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You will need to
rm .git/hooks/pre-pushto push without runningmvn verify. The PMD tests and other static analyses will still run on GitHub actions, but it will also check tests without analyses, and let you merge regardless of whether any checks fail.