Client gets threads_per_worker=1 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces run time of TPI on 64 physical core AMD workstation from ~12 hours to ~3 hours. It looks like the default of Dask is to oversubscribe threads to cores. This is not a good default for computationally intensive workloads.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 75.41% 75.41%
=======================================
Files 11 11
Lines 850 850
=======================================
Hits 641 641
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Great catch, @talumbau! Merging. |
|
@talumbau and @jdebacker. It will be interesting to see what this does to Jason and my run times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces run time of TPI on 64 physical core AMD workstation from ~12 hours to ~3 hours. It looks like the default of Dask is to oversubscribe threads to cores. This is not a good default for computationally intensive workloads.