[WIP] uavcannode: add global navigation solution #22235
Draft
+136
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Oct 18, 2023
| { | ||
| using uavcan::navigation::GlobalNavigationSolution; | ||
|
|
||
| // vehicle_global_position -> uavcan::navigation::GlobalNavigationSolution |
There was a problem hiding this comment.
It would be better to do this with vehicle_local_position. The vehicle_global_position is just the local NED estimate reprojected with the ref_lat, ref_lon fields available in vehicle_local_position.
PX4-Autopilot/msg/VehicleLocalPosition.msg
Lines 47 to 53 in 6eae9fb
There was a problem hiding this comment.
Updated to vehicle_local_position and force pushed.
AlexKlimaj
force-pushed
the
pr-dronecan-global-navigation-solution
branch
from
fe5d239 to
d419bc6
Compare
AlexKlimaj
force-pushed
the
pr-dronecan-global-navigation-solution
branch
from
d419bc6 to
746d86c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.