Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKF2: origin reset cleanup #23590

Merged
merged 5 commits into from
Aug 28, 2024
Merged

EKF2: origin reset cleanup #23590

merged 5 commits into from
Aug 28, 2024

Conversation

bresch
Copy link
Member

@bresch bresch commented Aug 21, 2024

We now have 2 options to set the origin of the local frame:

  • set the origin given the lat/lon/alt of the origin
  • set the origin given the current lat/lon/alt of the vehicle

@bresch bresch added the EKF2 label Aug 21, 2024
@bresch bresch requested review from dagar and haumarco August 21, 2024 15:53
@bresch bresch self-assigned this Aug 21, 2024
src/modules/ekf2/EKF/ekf.cpp Outdated Show resolved Hide resolved
@hamishwillee
Copy link
Contributor

@bresch I thought the EKF2 origin was effectively the position of the IMU on boot. Does this change anything for docs/user-facing behaviour?

@bresch bresch force-pushed the pr-ekf2-origin-reset-cleanup branch 4 times, most recently from f7f4e38 to 73c3bad Compare August 23, 2024 08:29
@bresch
Copy link
Member Author

bresch commented Aug 23, 2024

I thought the EKF2 origin was effectively the position of the IMU on boot. Does this change anything for docs/user-facing behaviour?

@hamishwillee By default it is, yes, but the user can change it by sending a mavlink command.

src/modules/ekf2/EKF/ekf.h Outdated Show resolved Hide resolved
src/modules/ekf2/EKF/ekf.h Outdated Show resolved Hide resolved
@bresch bresch force-pushed the pr-ekf2-origin-reset-cleanup branch from 73c3bad to 2667a14 Compare August 23, 2024 13:41
@bresch bresch requested a review from dagar August 23, 2024 14:51
@bresch bresch force-pushed the pr-ekf2-origin-reset-cleanup branch from 2667a14 to 27dc784 Compare August 26, 2024 09:55
@bresch bresch force-pushed the pr-ekf2-origin-reset-cleanup branch from c6f12d6 to c480c69 Compare August 27, 2024 11:40
@bresch bresch enabled auto-merge (rebase) August 27, 2024 11:40
bresch added 5 commits August 28, 2024 10:13
Allow partial resets (only lat/lon or only altitude)
This is not only needed when GNSS is available but also for other global
sources of position (e.g.: aux global pos and manual pos updates)
@bresch bresch force-pushed the pr-ekf2-origin-reset-cleanup branch from c480c69 to ab39a9d Compare August 28, 2024 08:32
@bresch bresch disabled auto-merge August 28, 2024 09:02
@bresch bresch merged commit bab256b into main Aug 28, 2024
55 checks passed
@bresch bresch deleted the pr-ekf2-origin-reset-cleanup branch August 28, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants