Commander: lock down mav_sys_id and mav_comp_id #23601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Aug 23, 2024
dagar
reviewed
Aug 23, 2024
dagar
reviewed
Aug 23, 2024
dagar
reviewed
Aug 23, 2024
dagar
reviewed
Aug 23, 2024
mrpollo
force-pushed
the
mrpollo/restrict_sys_id_set
branch
from
6ad1ae0 to
cc95bd5
Compare
- keeps them as local params at init - only allow to set at init
mrpollo
force-pushed
the
mrpollo/restrict_sys_id_set
branch
from
ca748ad to
81cc7b6
Compare
dagar
approved these changes
Aug 23, 2024
|
cc @ryanjAA |
|
@mrpollo thanks :) Backported and tested on local 1.14. Works as intended. If interested can backport to release 1.14. |
ryanjAA
added a commit
to ryanjAA/PX4-Autopilot
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allow setting
MAV_SYS_IDandMAV_COMP_IDwhen initializing commander, similar to the implementation in the mavlink module.fixes #22542
px4-mav_sys_id-changes-compressed.mp4