Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix container builds for PRs and sets proper PX4 git tags #24136

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mrpollo
Copy link
Contributor

@mrpollo mrpollo commented Dec 19, 2024

fixes #24134

@mrpollo mrpollo force-pushed the mrpollo/fix_container_invalid_arg branch from 689e1ed to e8c8833 Compare January 10, 2025 18:29
@mrpollo mrpollo force-pushed the mrpollo/fix_container_invalid_arg branch from 3c5854c to f1ca2f3 Compare January 10, 2025 20:15
@mrpollo mrpollo marked this pull request as ready for review January 10, 2025 20:15
@mrpollo mrpollo changed the title ci: test px4 docker run repo updates ci: fixes container builds for PRs and guarantees proper PX4 git tags Jan 10, 2025
@mrpollo mrpollo changed the title ci: fixes container builds for PRs and guarantees proper PX4 git tags ci: fixes container builds for PRs and sets proper PX4 git tags Jan 10, 2025
@mrpollo mrpollo changed the title ci: fixes container builds for PRs and sets proper PX4 git tags ci: fix container builds for PRs and sets proper PX4 git tags Jan 10, 2025
type=ref,event=branch,value=${{ steps.px4-tag.outputs.tag }},priority=700
type=ref,event=branch,suffix=-{{date 'YYYY-MM-DD'}},priority=600
type=ref,event=branch,suffix=,priority=500
type=raw,enable=true,value=${{ steps.px4-tag.outputs.tag }},priority=1000
Copy link
Contributor Author

@mrpollo mrpollo Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: this is the actual fix

-- type=ref,event=branch,value=${{ steps.px4-tag.outputs.tag }},priority=700
++ type=raw,enable=true,value=${{ steps.px4-tag.outputs.tag }},priority=1000

@dagar dagar merged commit 0723f75 into main Jan 14, 2025
61 checks passed
@dagar dagar deleted the mrpollo/fix_container_invalid_arg branch January 14, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Container build ci workflow intermitent issues
2 participants