Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbgecom: Implement sbgECom INS driver #24137

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tolesam
Copy link

@tolesam tolesam commented Dec 19, 2024

New Feature

Implement sbgECom messages handling to provide IMU sensors, GNSS and EKF data to the autopilot
Be able to parametrize the serial port, baudrate and the communicating mode
Clone sbgECom library only if sbgecom support is enabled and apply a patch
Be able to send SBG Systems INS settings in several ways when starting sbgecom driver

Bug Fixes

Fix sensor airspeed simulator units
Fix HIGHRES_IMU pressure unit
Don't build INS drivers by default on some boards to avoid overflowing FLASH memory region

@tolesam tolesam changed the title Implement sbgECom INS driver sbgecom: Implement sbgECom INS driver Dec 20, 2024
@saengphet
Copy link

Hello @tolesam I have a question. Does this PR intend to be used with the Ellipse Series, Ellipse 2 Micro Series, or both?

I'm interested in SBG products.

@tolesam
Copy link
Author

tolesam commented Dec 21, 2024

Hello @tolesam I have a question. Does this PR intend to be used with the Ellipse Series, Ellipse 2 Micro Series, or both?

I'm interested in SBG products.

Hello @saengphet,
It's intended to be used with all SBG Systems' INS products.
Feel free to give us any feedback about it, we'll be happy to help you with our products' integration with this driver.
Regards,
Samuel Toledano

@tolesam tolesam force-pushed the dev/sbgecom_driver branch 2 times, most recently from 72a92c0 to ffe24c4 Compare January 9, 2025 09:16
@tolesam
Copy link
Author

tolesam commented Jan 10, 2025

Hi @dagar ,

Can you take a look at this PR please?
I see you've already integrated another INS driver and we would be happy to have sbgecom driver available on PX4 firmware as well.

Moreover, it seems the job "Build and Push Container" doesn't work on PRs, do you have any idea why?
I tried to run it locally on ubuntu-latest and it worked well.

Thanks in advance.

@tolesam tolesam force-pushed the dev/sbgecom_driver branch 2 times, most recently from 5486f66 to 862fbd7 Compare January 14, 2025 11:59
Samuel Toledano added 5 commits January 14, 2025 18:01
Implement sbgECom messages handling to provide IMU sensors, GNSS and EKF data to the autopilot
Be able to parametrize the serial port, baudrate and the communicating mode
Clone sbgECom library only if sbgecom support is enabled and apply a patch
Be able to send SBG Systems INS settings in several ways when starting sbgecom driver
@tolesam tolesam force-pushed the dev/sbgecom_driver branch from 862fbd7 to 7627a34 Compare January 14, 2025 17:01
@@ -0,0 +1,124 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you didn't intended to commit this patch file

Copy link
Author

@tolesam tolesam Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on purpose.
I use FetchContent CMake method to get sbgECom public library only when the driver is enabled instead of getting it anyway with gitmodules.
And I apply this patch file to adapt sbgECom library to PX4 environment.

@tolesam tolesam requested a review from bresch January 15, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants