Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gz: increase timeout for service request #24164

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gz: increase timeout for service request #24164

wants to merge 2 commits into from
+9 −9

Conversation

dakejahl
Copy link
Contributor

@dakejahl dakejahl commented Jan 3, 2025 •
edited
Loading

Closes #23705
Closes #23809

@dakejahl dakejahl mentioned this pull request Jan 3, 2025
Open
@leechor
Copy link

leechor commented Jan 3, 2025

Closes #23705 Closes #23809

it works for me, by the way, line 915 maybe modified too.

@dakejahl dakejahl requested a review from Jaeyoung-Lim January 15, 2025 05:52
Jaeyoung-Lim
Jaeyoung-Lim requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is called on a loop. Wouldn't it make sense to modify the user message that it is retrying, rather than increase the timeout?

@dakejahl
Copy link
Contributor Author

This is called on a loop. Wouldn't it make sense to modify the user message that it is retrying, rather than increase the timeout?

I think not having the warning in the first place is optimal. I also updated the text and changed from err to warn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaeyoung-Lim Jaeyoung-Lim Awaiting requested review from Jaeyoung-Lim

@dagar dagar Awaiting requested review from dagar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dakejahl @leechor @Jaeyoung-Lim