-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make control allocation and actuator effectiveness a non-module-specific library #24196
Conversation
0028f92
to
a164aa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make ControlAllocation and ActuatorEffectiveness a library
I would consider having it grouped in one folder, as one cannot live without the other one.
Otherwise I agree with libraries as much as makes sense, and it should incentivize us to make certain functions more generic while going very specific for others.
326ff29
to
b257fe9
Compare
@sfuhrer Great, I have grouped the libraries to a directory as requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This might be nitpicky, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Daniel. I think there is no hurt in calling the folder "control_allocation" to be as precise as possible.
Keep actuator effectivenss in control allocator
af7a622
to
3a61839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean, thanks for the initiative!
Solved Problem
When trying to implement a separate metric control allocation module, it seems that sharing the control allocation library seems like a sensible solution.
Solution
ControlAllocation
andActuatorEffectiveness
a library that can be shared across multiple modulescontrol_allocator
module and only keep theActuatorEffectiveness
base class in the library.Changelog Entry
For release notes:
Test coverage
Tested in SITL
Context