-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control allocation: make heli rpm control an optional build flag disabled by default #24217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled by default to save flash. The rpm capture dirver is also disabled on default releases
bresch
approved these changes
Jan 15, 2025
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: -1432 byte (-0.07 %)]
px4_fmu-v6x [Total VM Diff: -1432 byte (-0.07 %)]
Updated: 2025-01-15T13:19:41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
After I merged #24096 @bresch reminded me that v6x now overflows flash.
Solution
Make heli rpm control a separate optional build flag (for now).
The rpm capture driver is also disabled on default releases.
Changelog Entry
Alternatives
Test coverage
For me locally
make px4_fmu-v6x
comes down from1744 bytes
to304 bytes
overflowed 😬so it doesn't free enough flash because it seems we were exactly at the limit before that pr or added more flash use since.