Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New world models and the Intel RealSense D435i model have been added #74

Closed
wants to merge 0 commits into from

Conversation

serkanMzlm
Copy link

Thanks to the new RealSense model, the camera was positioned facing downward to enable VIO, and it was tested with PX4-Autopilot. It worked successfully.

Screenshot from 2025-02-13 08-25-32

New world models with different environments have been added. To prevent the simulation program from being overloaded, collision elements of other objects within these models have been removed.

Screenshot from 2025-02-13 08-27-56

Screenshot from 2025-02-13 08-28-15

Screenshot from 2025-02-13 08-28-27

Screenshot from 2025-02-13 08-29-18

@dakejahl
Copy link
Contributor

Thanks for this! I tried testing, looks like we're missing the cube model

[Err] [Server.cc:86] Error Code 14: [/sdf/world[@name="maze"]/include[0]/uri:/home/jake/code/jake/PX4-Autopilot/Tools/simulation/gz/worlds/maze.sdf:L199]: Msg: Unable to find uri[model://cube]
[Err] [Server.cc:86] Error Code 14: [/sdf/world[@name="maze"]/include[1]/uri:/home/jake/code/jake/PX4-Autopilot/Tools/simulation/gz/worlds/maze.sdf:L205]: Msg: Unable to find uri[model://cube]
WARN  [gz_bridge] Service call timed out. Check GZ_SIM_RESOURCE_PATH is set correctly.
ERROR [gz_bridge] Task start failed (-1)
ERROR [init] gz_bridge failed to start and spawn model
ERROR [px4] Startup script returned with return value: 256
^Cninja: build stopped: interrupted by user.
make: *** [Makefile:232: px4_sitl] Interrupt

Another thing I am wondering is if we want to bring in all of these models. @Jaeyoung-Lim what do you think?

Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each model that is part of this repository tests a specific feature in PX4.

Could you elaborate why adding this model provides value?

@dakejahl
Copy link
Contributor

Could you elaborate why adding this model provides value?

I will say we really could use a better world. Then I wouldn't need to do this non-sense 😅
(mr meseeks tiled image for ground texture)
https://github.com/PX4/PX4-gazebo-models/pull/75/files#diff-5131df54faa4c244d4422beef1a07dc822b9802227ed3ae0a7825427618303c2

</include>
<joint name="CameraJoint" type="fixed">
<parent>base_link</parent>
<child>realsense_d435i/base_link</child>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<child>realsense_d435i/base_link</child>
<child>camera_link</child>

<pose>0 0 0 0 0 0</pose>
<self_collide>false</self_collide>
<static>false</static>
<link name="realsense_d435i/base_link">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<link name="realsense_d435i/base_link">
<link name="camera_link">

<pose>0 0 0 0 0 0</pose>
<visualize>true</visualize>
<update_rate>30</update_rate>
<topic>distance_sensor</topic>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, we can't specify absolute topic name, because it will appear as

/distance_sensor

and will not work when there are multiple models with a distance sensor

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

burada da aynı, mutlak konu adı belirtemeyiz çünkü şu şekilde görünecektir:

/distance_sensor

ve mesafe sensörüne sahip birden fazla model olduğunda çalışmayacaktır

Yes, I didn’t consider this part. My goal was to receive the data for VIO, but instead of specifying the topic name, having it directly under the vehicle’s name might be more useful.

<sensor name="imu_sensor" type="imu">
<always_on>1</always_on>
<update_rate>250</update_rate>
<topic>imu</topic>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<topic>imu</topic>

<always_on>1</always_on>
<update_rate>30</update_rate>
<visualize>true</visualize>
<topic>camera/left</topic>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<topic>camera/left</topic>

<sdf version="1.9">model.sdf</sdf>
<author>
<name>Jaeyoung Lim</name>
<email>[email protected]</email>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

<elevation>0</elevation>
</spherical_coordinates>
</world>
</sdf>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</sdf>
</sdf>

</visual>
</link>
</model>
</sdf>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</sdf>
</sdf>

}
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

@@ -240,4 +240,4 @@
<elevation>0</elevation>
</spherical_coordinates>
</world>
</sdf>
</sdf>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</sdf>
</sdf>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants