-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New world models and the Intel RealSense D435i model have been added #74
Conversation
Thanks for this! I tried testing, looks like we're missing the cube model
Another thing I am wondering is if we want to bring in all of these models. @Jaeyoung-Lim what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each model that is part of this repository tests a specific feature in PX4.
Could you elaborate why adding this model provides value?
I will say we really could use a better world. Then I wouldn't need to do this non-sense 😅 |
models/x500_realsense/model.sdf
Outdated
</include> | ||
<joint name="CameraJoint" type="fixed"> | ||
<parent>base_link</parent> | ||
<child>realsense_d435i/base_link</child> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<child>realsense_d435i/base_link</child> | |
<child>camera_link</child> |
models/realsense_d435i/model.sdf
Outdated
<pose>0 0 0 0 0 0</pose> | ||
<self_collide>false</self_collide> | ||
<static>false</static> | ||
<link name="realsense_d435i/base_link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<link name="realsense_d435i/base_link"> | |
<link name="camera_link"> |
models/realsense_d435i/model.sdf
Outdated
<pose>0 0 0 0 0 0</pose> | ||
<visualize>true</visualize> | ||
<update_rate>30</update_rate> | ||
<topic>distance_sensor</topic> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, we can't specify absolute topic name, because it will appear as
/distance_sensor
and will not work when there are multiple models with a distance sensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
burada da aynı, mutlak konu adı belirtemeyiz çünkü şu şekilde görünecektir:
/distance_sensor
ve mesafe sensörüne sahip birden fazla model olduğunda çalışmayacaktır
Yes, I didn’t consider this part. My goal was to receive the data for VIO, but instead of specifying the topic name, having it directly under the vehicle’s name might be more useful.
models/realsense_d435i/model.sdf
Outdated
<sensor name="imu_sensor" type="imu"> | ||
<always_on>1</always_on> | ||
<update_rate>250</update_rate> | ||
<topic>imu</topic> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<topic>imu</topic> |
models/realsense_d435i/model.sdf
Outdated
<always_on>1</always_on> | ||
<update_rate>30</update_rate> | ||
<visualize>true</visualize> | ||
<topic>camera/left</topic> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<topic>camera/left</topic> |
models/x500_realsense/model.config
Outdated
<sdf version="1.9">model.sdf</sdf> | ||
<author> | ||
<name>Jaeyoung Lim</name> | ||
<email>[email protected]</email> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
worlds/mountain.sdf
Outdated
<elevation>0</elevation> | ||
</spherical_coordinates> | ||
</world> | ||
</sdf> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</sdf> | |
</sdf> | |
models/land/model.sdf
Outdated
</visual> | ||
</link> | ||
</model> | ||
</sdf> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</sdf> | |
</sdf> | |
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} | |
worlds/default.sdf
Outdated
@@ -240,4 +240,4 @@ | |||
<elevation>0</elevation> | |||
</spherical_coordinates> | |||
</world> | |||
</sdf> | |||
</sdf> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</sdf> | |
</sdf> | |
Thanks to the new RealSense model, the camera was positioned facing downward to enable VIO, and it was tested with PX4-Autopilot. It worked successfully.
New world models with different environments have been added. To prevent the simulation program from being overloaded, collision elements of other objects within these models have been removed.