Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cameras: fix topic namespaces #76

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

dakejahl
Copy link
Contributor

Problem
User reported issue in multi-vehicle sim where all camera topics end up with the same name /camera

After this PR
Topics are namespaced properly

/world/default/model/x500_mono_cam_down_1/model/mono_cam/link/camera_link/sensor/imager/camera_info
/world/default/model/x500_mono_cam_down_1/model/mono_cam/link/camera_link/sensor/imager/image
/world/default/model/x500_mono_cam_down_2/model/mono_cam/link/camera_link/sensor/imager/camera_info
/world/default/model/x500_mono_cam_down_2/model/mono_cam/link/camera_link/sensor/imager/image

@th-grimaldi
Copy link

I'm the user in question. This change works. It would be helpful to extend this change to other cameras and drones as well, instead of only mono_cam and the x500_mono_cam_down sdfs.

@dakejahl dakejahl changed the title mono_cam: fix topic namespaces cameras: fix topic namespaces Feb 18, 2025
@dakejahl
Copy link
Contributor Author

I'm the user in question. This change works. It would be helpful to extend this change to other cameras and drones as well, instead of only mono_cam and the x500_mono_cam_down sdfs.

@th-grimaldi all camera models have been updated. Let me know if this works.

Copy link
Member

@beniaminopozzan beniaminopozzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dakejahl !
Tested on gz_x500_mono_cam, gz_x500_mono_cam_down and gz_x500_depth

@dakejahl dakejahl merged commit 183cbee into PX4:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants