Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in DenseScanner of DataProviderConverter. #1121

Merged
merged 1 commit into from
Jan 16, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jan 11, 2017

No description provided.

@reyoung reyoung requested a review from jacquesqiao January 11, 2017 09:45
@@ -47,6 +51,8 @@ def scan(self, dat):
def finish_scan(self, argument):
assert isinstance(argument, swig_paddle.Arguments)
assert isinstance(self.input_type, dp2.InputType)
if self.__mat__.dtype != numpy.float32:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

即使__mat__初始化成float32的类型,在numpy.append操作中,dtype还是有可能被修改成float64.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

什么情况下会中招?表现是啥

@reyoung reyoung added the Bug label Jan 11, 2017
@reyoung reyoung requested a review from QiJune January 11, 2017 09:46
@reyoung reyoung mentioned this pull request Jan 11, 2017
@@ -47,6 +51,8 @@ def scan(self, dat):
def finish_scan(self, argument):
assert isinstance(argument, swig_paddle.Arguments)
assert isinstance(self.input_type, dp2.InputType)
if self.__mat__.dtype != numpy.float32:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

什么情况下会中招?表现是啥

@reyoung reyoung mentioned this pull request Jan 11, 2017
@reyoung reyoung merged commit c397e13 into PaddlePaddle:develop Jan 16, 2017
@reyoung reyoung deleted the feature/fix_ndarray_dtypes branch January 16, 2017 04:14
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019
* test=document_preview

* 0823 update FluidDoc,test=document_preview

* add two files
wangxicoding pushed a commit to wangxicoding/Paddle that referenced this pull request Dec 9, 2021
lizexu123 pushed a commit to lizexu123/Paddle that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants