Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] Get dtensor from ShardDataloader #10009

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Xing-lil
Copy link
Contributor

@Xing-lil Xing-lil commented Mar 6, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

New features

PR changes

Others

Description

get dtensor from ShardDataloader and acc split

Copy link

paddle-bot bot commented Mar 6, 2025

Thanks for your contribution!

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 50.38%. Comparing base (51ea8a4) to head (0a9a0a1).
Report is 13 commits behind head on develop.

Current head 0a9a0a1 differs from pull request most recent head 7846c0e

Please upload reports for the commit 7846c0e to get more accurate results.

Files with missing lines Patch % Lines
paddlenlp/trainer/auto_trainer.py 0.00% 14 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (50.38%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10009      +/-   ##
===========================================
+ Coverage    50.35%   50.38%   +0.02%     
===========================================
  Files          756      756              
  Lines       121559   121665     +106     
===========================================
+ Hits         61216    61302      +86     
- Misses       60343    60363      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

global_micro_batchs[index][key].append(dist.reshard(data, mesh, placements))
else:
global_micro_batchs[index].update({key: [dist.reshard(data, mesh, placements)]})
if self.dense_tensor_idx is not None and j in self.dense_tensor_idx:
Copy link
Contributor

@jeff41404 jeff41404 Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in another branch in L291 above should also be modified like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, updated the other branch in L291 as well.

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants