-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoParallel] Get dtensor from ShardDataloader #10009
base: develop
Are you sure you want to change the base?
Conversation
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #10009 +/- ##
===========================================
+ Coverage 50.35% 50.38% +0.02%
===========================================
Files 756 756
Lines 121559 121665 +106
===========================================
+ Hits 61216 61302 +86
- Misses 60343 60363 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paddlenlp/trainer/auto_trainer.py
Outdated
global_micro_batchs[index][key].append(dist.reshard(data, mesh, placements)) | ||
else: | ||
global_micro_batchs[index].update({key: [dist.reshard(data, mesh, placements)]}) | ||
if self.dense_tensor_idx is not None and j in self.dense_tensor_idx: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in another branch in L291 above should also be modified like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, updated the other branch in L291 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before submitting
tests
folder. If there are codecov issues, please add tests cases first.PR types
New features
PR changes
Others
Description
get dtensor from ShardDataloader and acc split