Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap model when lora is ON and only do evaluation. #9803

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

wtmlon
Copy link
Collaborator

@wtmlon wtmlon commented Jan 21, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

PR changes

Description

wrap model when lora is ON and only do evaluation.

@wtmlon wtmlon requested review from ZHUI and gongel and removed request for ZHUI January 21, 2025 12:41
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.35%. Comparing base (ac095f5) to head (22d0489).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9803      +/-   ##
===========================================
+ Coverage    51.27%   52.35%   +1.07%     
===========================================
  Files          735      730       -5     
  Lines       121550   115522    -6028     
===========================================
- Hits         62329    60476    -1853     
+ Misses       59221    55046    -4175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

@ZHUI ZHUI merged commit e247c85 into PaddlePaddle:develop Jan 23, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants