Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TaskFlow] Fix pir for taskflow #9822

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

DrownFish19
Copy link
Collaborator

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

Fix taskflow when PIR=ON.

Copy link

paddle-bot bot commented Jan 24, 2025

Thanks for your contribution!

ZHUI
ZHUI previously approved these changes Jan 24, 2025
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (eab22f2) to head (09ea16d).

Current head 09ea16d differs from pull request most recent head 20fa6a3

Please upload reports for the commit 20fa6a3 to get more accurate results.

Files with missing lines Patch % Lines
paddlenlp/taskflow/task.py 20.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (20.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (52.20%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9822   +/-   ##
========================================
  Coverage    52.19%   52.20%           
========================================
  Files          731      730    -1     
  Lines       115882   115851   -31     
========================================
- Hits         60489    60483    -6     
+ Misses       55393    55368   -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -25,15 +25,19 @@
import paddle
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此文件经过pre-commit修改,多为格式修改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants