Fix create race condition #380
Conversation
…can return a 404 on create
…rduty services retry.
…p, user contact, and notifications rules to have similar safeguards against eventual consistent reads.
|
@stmcallister Apologies for the direct ping but I see you are a consistent contributor to this repo. Are there any guidelines on how to get reviewers added to this PR and any next steps to get this one merged. Thanks! |
|
@drastawi I noticed that you have also been involved in some prs recently. Am I missing anything to get this work reviewed? |
|
@eric-spence-code sorry for letting this sit so long! can you resolve the conflicts? I'll be sure to review it soon after the conflicts are resolved. Thanks! |
|
@stmcallister all good! I will get those conflicts resolved. Anything else needed for this pr to get merged |
|
@eric-spence-code as far as i can tell, without testing, it looks pretty good! |
|
@eric-spence-code were you ready for me to test? I saw some activity on the PR and gave it another try but ran into some issues with this code in the What I'm seeing is this code: Throws an error The other functions are building Is there advantage to using |
|
@stmcallister nah its just a bad merge. I will update them all to use the same client constructor. |
- Fix merge issues.
…pence-code/terraform-provider-pagerduty into fix-create-race-condition
|
@eric-spence-code also, can you merge in the latest master as well? I'm still getting conflicts with recent changes to master. |
…der-pagerduty into fix-create-race-condition
|
@stmcallister just pulled in upstream and I am not seeing any conflicts. Are you saying merge conflicts or failing tests? |
Addressing race conditions on creates where resources immediately GET after creating #273 . Similar to GH-274 but addressing it by allowing callers to pass in a different error callback based on what the invoking function wants the error behavior to be.