schedule: Validate daily/weekly restrictions #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow a daily restriction that spans a full 24*time.Hour and similar for weekly restrictions. The PD API rejects 24*time.Hour and 24*7*time.Hour for the API.
stmcallister
suggested changes
Jan 20, 2022
There was a problem hiding this comment.
Oooo! I like this solution! It's really readable AND you have tests!!! 😍 I just merged #433 which accomplishes the same thing, but I would also like this one because of readability and the included tests. However, when I run the tests with the newly merged code the test fails with the following message. If you could fix this I would love to merge it in to the project.
=== RUN TestAccPagerDutySchedule_BasicWeek
resource_pagerduty_schedule_test.go:216: Step 3/3, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1
Error: expected layer.0.restriction.0.duration_seconds to be in the range (1 - 604799), got 604800
with pagerduty_schedule.foo,
on terraform_plugin_test.tf line 23, in resource "pagerduty_schedule" "foo":
23: duration_seconds = 604800
--- FAIL: TestAccPagerDutySchedule_BasicWeek (12.00s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow a daily restriction that spans a full 24time.Hour
and similar for weekly restrictions. The PD API rejects 24time.Hour
and 247time.Hour for the API.