Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a fresh terraform binary if we're unable to locate a matching version in PATH. #941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdborton
Copy link

So full disclosure... I don't know go. I stumbled my way through this and managed to run a simple test w/ vscode.

I'm not sure if this is the best approach to fix the problem that I'm seeing, but I want to try to move along the fix as much as I can.

This is meant to address an issue that we're seeing atm in Terraform Cloud. We get this message when trying to apply our plan:

terraform binary version >= 1.0.6 not found in $PATH

I looked through the commit history and spotted that this was changed in March to not download a fresh binary. I tried reverting our usage to the version that pulls a fresh binary, but then hit this message:
image

According to this SO post it seems to be a requirement of 1.1 in Terraform Cloud while the older version of this provider installs 1.0.6.

I took a screenshot of my poorly written test output (since deleted as I don't know go and couldn't write the mocks):
image

@gdborton
Copy link
Author

Following up here as we managed to get past this issue. It seems that this helper file is only invoked if you're deleting a team that is used in an escalation policy with only a single layer. In our case we were "renaming" the team, but this was being applied as a delete/recreate.

We were able to unblock by manually adding an additional layer to the blocking escalation policy. TF was then able to do it's thing.

I don't know if the logic in this PR exactly needs to land, but there definitely is a bug today in the PagerDuty TF provider than surfaces in TF Cloud when you invoke this helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant