Universal bootloader #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taminomara
reviewed
Jan 24, 2025
| if code then | ||
| -- We don't really expect this to return | ||
| computer.log(0, "Starting " .. name) | ||
| local success, error = pcall(code) |
There was a problem hiding this comment.
Consider using xpcall to display proper traceback:
Suggested change
| local success, error = pcall(code) | |
| local success, error = xpcall(code) | |
| if not success then | |
| computer.log(3, error.message.."\n"..error.trace) |
| end | ||
| end | ||
|
|
||
| function bootloader:loadModule(name) |
There was a problem hiding this comment.
I think loadModule should check if a module with this name was already loaded (or in progress of loading), and skip it. Otherwise, a module might be loaded twice if a user manually calls bootloader:loadModule("display.lua").
taminomara
reviewed
Jan 25, 2025
| local content = self:loadCode(name) | ||
| if content then | ||
| computer.log(0, "Parsing loaded content") | ||
| local code, error = load(content) |
There was a problem hiding this comment.
Also, you can pass the module name to the load function to enhance tracebacks even further:
Suggested change
| local code, error = load(content) | |
| local code, error = load(content, name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the README for details.