Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few small changes to make the Mac build happy:
long
, so I've swapped toint64_t
there....I've been using this locally on mac for the past 12 months or so, but I (and ideally someone else) need to test this on Linux.To help prevent this again, I've also bumped the CI to more modern versions (GCC 12 to match LArSoft v10_00_X, and the latest Clang in Ubuntu 24.04), as well as fixing a few other bits in the CI (i.e. bumping the tools we use in the actions to their latest versions, to prevent some deprecation warnings).
The ROOT and LibTorch versions used here should match the versions used by LArSoft V10_00_02.
Whilst testing this in my local branch, I found that when jumping to the newer compiler versions, I got even more "set but not used variable" warnings, so I've fixed them too.
There is maybe also a question of if we want to bother adding a Mac config to the CI....that would catch these errors quickly, but would be an extra thing running each time (and make the CI config a touch more complicated to support picking the right versions of ROOT / LibTorch, setup steps etcetc).