-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Cantonese support, fixed some bugs. #11
base: master
Are you sure you want to change the base?
Conversation
…g. Ctrl), but that modifier key is not in use by LiuChan, LiuChan would still try to interpret the key. For example, user wishes to copy (Ctrl+C) some text, does not have Ctrl as a modifier key. Then LiuChan would (before this fix) interpret the pressed C to copy the dictionary text, when really user expects the behaviour of Ctrl+C not to be changed.
Which dictionary are you using for cantonese? Is it CC-Canto from http://cantonese.org/? edit: |
The raw data comes from CC-Canto and the CC-CEDICT Cantonese readings (both from cantonese.org), these were processed into a single file. You're welcome! |
This is great! Tested it and it resolves an issue with words like 捨棄 failing to be looked up that has been constantly annoying me, is there anything blocking this from being merged? |
fix incorrect zhuyin - mo corresponds to ㄇㄛ (\u3107\u311b) not ㄇㄨㄛ (\u3107\u3128\u311b)
I noticed that with this branch jyutping seems to be unavailable for 律 and all words containing it ie 法律,律师,旋律,音律,因果律,定律,菲律宾 - I'm not sure why |
Found the reason for the above error, it looks like the scripts that generates cedict_combined.u8 might have some bugs as it doesn't seem to include jyutping everywhere. See the below (jyutping should be between the { } )
|
Oh this seems to impact every word containing a character that has pinyin pronunciation v (u:), like 女,绿,吕,驴. Presumably an issue with the script that generates cedict_combined.u8 (which unfortunately doesn't seem to be included in the repository) |
I wrote a big message just now about how in general I've tried to avoid autocompleting jyutpings on a per-character basis (leads to many errors, even the Pleco dictionary on iPhone has it, which uses a better version of the CC-Canto sources AFAIK). But you're right, actually in this case it's my fault and that there is a bug in the generator scripts. In fact, the entry is double-entered; somewhere else in the file: For now, I've attached the dictionary generator scripts. I didn't include them in the branch since I thought I would quickly clean them up and include some autocomplete system that also gave correct results (but that's actually a much harder problem than I thought it was). Thanks again for pointing this out. |
@Paperfeed Any chance this can get merged and deployed to the Chrome Web Store? I'm interested in being able to use Cantonese and can help push this along if more changes are needed |
Added Cantonese pronunciation support
Main features added:
Fixed bugs, notably: