Show the popup only in Chinese pages #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an extension option that allows users to opt in to show the popup only if the browser detects the current page's language to be Chinese. This is useful for users who read Japanese or Korean pages on a regular basis.
|
Hey, so sorry for getting back to you so late. Somehow I completely missed this PR being opened. I will be happy to make a new release with these changes incorporated. I also need to update the manifest to v3. |
|
Hi apologies for missing your reply for quite some time, it will be great if you can merge this & update the manifest - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, first of all thanks so much for creating this wonderful extension!
As a Mandarin learner myself it has been a great experience using LiuChan, but I sometimes find it inconvenient how the popup shows up even on websites in Japanese, because of the overlap between many Hanzi/Kanji characters.
This PR comes with an option (disabled by default) that uses Chrome API to detect language of the current page, and disables the content script if the language code is neither
zh-CNnorzh-TW.I understand this is no longer actively developed, but it'd be great if you could merge this - it'll be really helpful for Japanese (or Korean) readers!
Also here's some screenshots:
Screen.Recording.2024-04-04.at.21.31.14.mov