Radios with a range of 0 no longer broadcast to the entire tile. #24766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FunnyMan3595
added
Revert/Feature Removal
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
|
no more walking over beepsky for free sec comms 🫡 |
|
oooh no more getting caught cause an officer walked past you while a syndicate researcher proclaims they've made yet another bomb over the syndicomms |
GDNgit
reviewed
Mar 23, 2024
ParadiseSS13-Bot
added
-Status: Awaiting review
Turns out, this is faster than merging the two lists at the start.
S34NW
approved these changes
Apr 12, 2024
ParadiseSS13-Bot
added
-Status: Awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Radios with a range of 0 are now only sent to listeners that are part of the same root atom (the one whose loc is the turf).
Why It's Good For The Game
Fixes #24764. Prevents people from hearing your headset by crawling under you.
Testing
Went to a wall radio. Turned it to hotmic, but not speaker. Spoke. Heard radio.
Took off my headset. Spoke. No radio.
Got a station-bounced radio, set its canhear_range to 0. Spoke. Heard radio.
Put the radio in my backpack. Spoke. Heard radio.
Dropped radio. Spoke. No radio.
Made a mouse, picked it up. Became the mouse. Spoke. No radio
Had the human wear their headset again. Went back to mouse. Spoke. Heard radio.
Changelog
🆑
del: It's no longer possible to hear 0-range radios (like headsets) anywhere on the same tile. You must be part of the same top-level object, e.g. a mouse held by the person wearing the headset.
/:cl: