Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes tgui alerts taking WAY longer than they should to delete #24859

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fixes tgui alerts taking WAY longer than they should to delete #24859

merged 1 commit into from
Mar 28, 2024

Conversation

GDNgit
Copy link
Contributor

@GDNgit GDNgit commented Mar 28, 2024

What Does This PR Do

fixes tgui alerts taking WAY longer than they should to delete
Before: Around ~25MS to delete

[2024-03-28T19:14:18] Path: /datum/tgui_list_input
[2024-03-28T19:14:18] 	qdel() Count: 164
[2024-03-28T19:14:18] 	Destroy() Cost: 4057.33ms

After:
lmao thanks dm

Why It's Good For The Game

GC GO VROOM
This is the highest qdel cost atm

Testing

see above for a screenshot

Changelog

NPFC

@SteelSlayer SteelSlayer added Performance This will increase performance on the server GC Related This PR optimises how a type GCs labels Mar 28, 2024
@SteelSlayer SteelSlayer added this pull request to the merge queue Mar 28, 2024
Merged via the queue into ParadiseSS13:master with commit b1988e7 Mar 28, 2024
11 checks passed
Daylight2 pushed a commit to Daylight2/Paradise that referenced this pull request Apr 8, 2024
@GDNgit @Daylight2
fixes tgui alerts taking WAY longer than they should to delete (Parad…
328e84a 
…iseSS13#24859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteelSlayer SteelSlayer SteelSlayer approved these changes

Assignees
No one assigned
Labels
GC Related This PR optimises how a type GCs Performance This will increase performance on the server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GDNgit @SteelSlayer