Custom, crew-buildable vendors #28009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
|
Looks like we'll need #27784 to merge before this, since the migration on /obj/machinery/economy wasn't sufficient. |
ParadiseSS13-Bot
added
-Status: Awaiting approval
|
I recall these existing over on tg and causing a minor kerfuffle when someone tossed the NAD in one and set it for 30000 credits or something, so you may want to ensure that's covered if you haven't already. |
I mean, you can, but then someone can just break it and pick the NAD up from the pile of stuff. The vendor is only protected against screwdriver + crowbar disassembly, not any other destruction method. |
|
Holy shit, based |
ParadiseSS13-Bot
added
-Status: Awaiting review
warriorstar-orion
approved these changes
Jan 28, 2025
Burzah
reviewed
Jan 28, 2025
FunnyMan3595
commented
Jan 28, 2025
Co-authored-by: Burzah <[email protected]> Signed-off-by: Charlie Nolan <[email protected]>
Burzah
approved these changes
Jan 28, 2025
ParadiseSS13-Bot
added
-Status: Awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Adds the ability for vendors to hold actual items (rather than just typepaths), and uses it to implement a custom vendor type, which is available in the vending board and as a kit in the bar and kitchen vendors.
Why It's Good For The Game
Custom vendors are not only fun for admin use, they allow chefs, cooks, and other folks with stuff to sell to do it in a standardized way.
Images of changes
2025-01-17.02-38-00.mp4
Testing
Made above video.
Disassembled a custom vendor without a linked POS.
Deconstructed and destroyed a custom vendor with stuff in it. Got the stuff back both times.
Used an ATM, merch vendor, and claw machine (all the collateral migrations).
Tried to do various things that should prevent inserting an item after getting the price prompt.
Declaration
Changelog
🆑
add: Custom vendors that you can load and buy from. The chef and bartender can buy a kit from their vendor, and they can be built with a vending machine board like any other vender, but don't require a restocking kit.
/:cl: