Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch a CE Lose Their Sanity in Real Time: Adding Water Vapor and Hydrogen #28384

Draft
wants to merge 81 commits into
base: master
Choose a base branch
from

Conversation

haydenredacted
Copy link
Contributor

@haydenredacted haydenredacted commented Feb 14, 2025

What Does This PR Do

Adds two new gases, Hydrogen and Water Vapor along with an electrolyzer machine which takes in water vapor and produces hydrogen and oxygen. Atmospherics on each station starts with one, however the board can be printed at RnD.

Discord discussion at: https://discord.com/channels/145533722026967040/1340013012773244970

Why It's Good For The Game

Atmos content is good. I'd like for there to be more gases and gas reactions.

Images of changes

image

Testing

Game compiles, server boots
Hydrogen/Water Vapor are detectable by gas analyzers
Hydrogen ignites with oxygen at a set temperature
Air alarms detect and scrub Hydrogen/Water
Portable scrubbers scrub the new gases
Gas filters filter Hydrogen/Water Vapor


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: adds Hydrogen, an explosive gas able to react with Oxygen
add: adds Water Vapor, a gas that can cause the floor to become slick
add: Adds the Electrolzyer
/:cl:

Copy link
Contributor

paradisess13 bot commented Feb 14, 2025

Building Rust library failed, see the action run log for details: https://github.com/ParadiseSS13/Paradise/actions/runs/13321721950

@haydenredacted haydenredacted marked this pull request as draft February 14, 2025 03:18
Copy link
Contributor

paradisess13 bot commented Feb 14, 2025

Building Rust library failed, see the action run log for details: https://github.com/ParadiseSS13/Paradise/actions/runs/13321806240

@haydenredacted
Copy link
Contributor Author

!build_rust

Copy link
Contributor

paradisess13 bot commented Mar 5, 2025

Building Rust library failed, see the action run log for details: https://github.com/ParadiseSS13/Paradise/actions/runs/13681884882

@haydenredacted
Copy link
Contributor Author

!build_rust

@haydenredacted
Copy link
Contributor Author

!build_rust

Copy link
Contributor

paradisess13 bot commented Mar 5, 2025

Building Rust library failed, see the action run log for details: https://github.com/ParadiseSS13/Paradise/actions/runs/13684389253

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Mar 6, 2025
@haydenredacted
Copy link
Contributor Author

!build_rust

Copy link
Contributor

paradisess13 bot commented Mar 6, 2025

Building Rust library failed, see the action run log for details: https://github.com/ParadiseSS13/Paradise/actions/runs/13703180707

@haydenredacted
Copy link
Contributor Author

!build_rust

@haydenredacted
Copy link
Contributor Author

!build_rust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Map Edit This PR will modify a map Sprites This PR modifies the game sprites Testmerge Requested This PR has a pending testmerge request TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants