Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some incorrect mappings #296

Draft
wants to merge 4 commits into
base: versions/1.21.x
Choose a base branch
from
Draft

fix some incorrect mappings #296

wants to merge 4 commits into from

Commits on Aug 5, 2024

  1. fix docs of ServerPlayer's closeContainer and co

    @BasiqueEvangelist
    BasiqueEvangelist committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5e55125 View commit details
    Browse the repository at this point in the history

  2. rename bypassHiddenChat to overlay 

    This flag doesn't just bypass chat visibility, it also puts the message
in the action bar. overlay is what the field in
ClientboundSystemChatPacket is called, so that's what I use here.
    @BasiqueEvangelist
    BasiqueEvangelist committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    324bc00 View commit details
    Browse the repository at this point in the history

  3. fix bad Container mappings

    @BasiqueEvangelist
    BasiqueEvangelist committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    fe47f15 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Matyrobbrt <[email protected]>
    @BasiqueEvangelist @Matyrobbrt
    BasiqueEvangelist and Matyrobbrt authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0253d0a View commit details
    Browse the repository at this point in the history