-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bahnv2 bike parking locked and open #172
Merged
the-infinity
merged 6 commits into
ParkenDD:main
from
mobidata-bw:add-bahnv2-bike-parking-sites
Jan 21, 2025
Merged
Add bahnv2 bike parking locked and open #172
the-infinity
merged 6 commits into
ParkenDD:main
from
mobidata-bw:add-bahnv2-bike-parking-sites
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-infinity
reviewed
Jan 3, 2025
9bb1df1
to
4254b08
Compare
Added some changes to make sure that there is always a valid value and rebased it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates existing
bahnv2
parking source converter by integrating the new capacity typesBIKE_PARKING_LOCKED
andBIKE_PARKING_OPEN
as separateParkingSite
withtype
ofLOCKBOX
andOTHER
respectively for bike parking. The existing mappings for car parkingtype
are not changed.The parking sites from Deutsche BahnPark
bahnv2
now havepurpose
asbike
andcar
, grouped intoParkingSiteGroup
.