Tests: Add PHP 8.4 and move PCOV to PHP 8.2 #2872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o refactor/internal-api-stats # Conflicts: # tests/Integration/RestAPI/ContentHelper/ContentHelperFeatureTestTrait.php
…elper REST API Refactor: Base classes and Content Helper namespace implementation
…f github.com:Parsely/wp-parsely into update/add-php-8.4-to-tests-and-move-pcov-to-php-8.2
|
I can confirm that tests now also run on PHP 8.4 in experimental mode, and that PHP 8.2 runs with code coverage. It's also worth noting that testing on PHP 8.4 surfaces some deprecation messages, and it seems that many integration tests are failing as well. Since many of the failures are about internal endpoints, I suggest merging our API refactoring work before tending to these. |
|
I tried to base this upon our refactoring branch, but chaos ensued, so I went back to develop for now. |
# Conflicts: # src/content-helper/dashboard-widget/class-dashboard-widget.php # src/rest-api/content-helper/class-endpoint-excerpt-generator.php
…tests-and-move-pcov-to-php-8.2
|
Closing in favor of #2878 because I broke this PR with changing bases. |
acicovic
deleted the
update/add-php-8.4-to-tests-and-move-pcov-to-php-8.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds PHP 8.4 to our unit and integration test matrices in experimental mode, as PHP 8.4 is on its merry way to release towards the end of November.
It also moves PCOV from using PHP 8.1 to 8.2, which is currently the most popular PHP version in the 8.x branch according to WordPress Stats.
Motivation and context
How has this been tested?