PCH Refactor: Refactor internal API and external services #2889
Conversation
…o refactor/internal-api-stats # Conflicts: # tests/Integration/RestAPI/ContentHelper/ContentHelperFeatureTestTrait.php
…elper REST API Refactor: Base classes and Content Helper namespace implementation
* Implement the new Content API service, and remove old RemoteAPI code * Implement caching mechanism for service endpoints * Implement the Suggestions API service * Address PHPCS & PHPStan errors and warnings * Fix post-merge issues and namespaces * Add condition when validate api credentials returns false. * Address code review feedback * Adjust some DocBlocks and whitespace * Make the services base URL static, and remove the old consts * Fix PHPStan (not including tests) * Fix misplaced `@since` tag --------- Co-authored-by: Alex Cicovic <[email protected]>
* Implement and update integration tests * Adjust some DocBlocks and whitespace * Adjust some DocBlocks and whitespace * Fix tests * Fix leaking tests * Apply code review suggestions * Remove backticks from function summary * Improve code formatting consistency between 2 tests --------- Co-authored-by: Alex Cicovic <[email protected]>
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 46 files out of 128 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
# Conflicts: # build/content-helper/editor-sidebar.asset.php # build/content-helper/editor-sidebar.js
acicovic
changed the title
acicovic
changed the title
|
We'll not be re-reviewing that code, since it has been already been reviewed per PR. Having said that, let's address the SonarCloud warnings if they have any merit. |
|
@acicovic SonarCloud fixed 🙂 |
There was a problem hiding this comment.
Phew! This was lots of work!
Thank you for your diligence and for getting this through the very end!
Let's merge this! This will allow us to merge the rest of the pending PRs, and have a test build for 3.17.0 soon! 🙂
If we find any bugs, we can address them in separate PRs.
acicovic
changed the title
Description
This PR is the final one related with the extensive refactoring of the internal REST API, and the external services. This is a combination of the following PRs:
All of these PRs have been reviewed and approved before merging to the
refactor/internal-apibranch.Motivation and context
How has this been tested?
Tested locally and through new and updated integration tests.