Remove unnecessary mention of ServicePulse #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udidahan
changed the title
udidahan
requested review from
PhilBastian,
johnsimons,
YifatS and
irinascurtu
YifatS
reviewed
Feb 2, 2025
PhilBastian
reviewed
Feb 3, 2025
| @@ -6,10 +6,11 @@ This showcase consists of 4 processes hosting MassTransit message producers and | |||
|
|
|||
| ## Launching the Showcase in Docker | |||
|
|
|||
| The showcase requires a connection to a broker (by default RabbitMQ), [ServiceControl](https://hub.docker.com/r/particular/servicecontrol) container, [ServicePulse](https://hub.docker.com/r/particular/servicepulse) container and the [MassTransit Connector for ServiceControl](https://hub.docker.com/r/particular/servicecontrol-masstransit-connector) container. | |||
There was a problem hiding this comment.
My opinion is that we still need this list of required containers, so that if someone is having an error in the showcase they can see what is in docker and understand what each container is there for
There was a problem hiding this comment.
I agree, but I think if we put that under the docs, that would probably be a better place for them. I can't see a good enough reason to keep them this prominent on the Readme.
There was a problem hiding this comment.
I put them under the troubleshooting section now.
irinascurtu
approved these changes
Feb 3, 2025
PhilBastian
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we don't want people to focus on names like ServicePulse or ServiceControl unnecessarily, preferring to keep the focus on the Service Platform.