Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics related samples to NServiceBus 9.1 #6777

Merged
merged 16 commits into from
Aug 23, 2024

Conversation

mauroservienti
Copy link
Member

@mauroservienti mauroservienti commented Jul 26, 2024

@lailabougria
Copy link
Contributor

@mauroservienti would you like me to take this off your plate?

I think what needed to be done was:

  • rerun the samples so the images can be updated
  • change the sample and inline parts in the docs so we can keep the shim in v9, but remove it in v9.1

Did I miss anything?

@mauroservienti
Copy link
Member Author

@mauroservienti would you like me to take this off your plate?

That would be great 😊

I think what needed to be done was:

  • rerun the samples so the images can be updated

Correct.

  • change the sample and inline parts in the docs so we can keep the shim in v9, but remove it in v9.1

We need to decide if we want to keep samples for v9, too. Usually, we only keep samples for the latest minor.

Did I miss anything?

We probably need to restructure the OpenTelemetry documentation because the various meter names, for example, are scattered around in multiple places; on many pages, we link to a centralized "Metrics" page where there is no mention of the OpenTelemetry meters. Whenever I read it, I find it puzzling.

@lailabougria lailabougria marked this pull request as ready for review August 22, 2024 18:31
@lailabougria lailabougria merged commit 26e926b into master Aug 23, 2024
4 checks passed
@lailabougria lailabougria deleted the update-metrics-related-samples-to-core-9.1 branch August 23, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants