Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration guide for Azure functions in-process to isolated worker host model #6782

Merged
merged 14 commits into from
Aug 9, 2024
Merged

Add migration guide for Azure functions in-process to isolated worker host model #6782

merged 14 commits into from
Aug 9, 2024

Conversation

TravisNickels
Copy link
Member

@TravisNickels TravisNickels commented Jul 31, 2024 •
edited by soujay
Loading

johnsimons
johnsimons requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@johnsimons johnsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, i have provided a few comments along the way

@soujay
Copy link
Contributor

soujay commented Jul 31, 2024 •
edited
Loading

@travis - I added in my suggestions.
It will also be good to mention about the following

  • The trigger name can remain the same. Eg: QueueTrigger is the attribute name in both.
  • Input bindings need the word input appended to the name eg: CosmosDB input binding is now called CosmosDBInput
  • Output bindings need the word output appended to the name eg: Queue output binding is now called QueueOutput
  • Visual studio offers a ".NET Upgrade Assistant" extension to help with the upgrade process.
  • Before migrating to isolated worker process, ensure that project has been updated to use AzureFunctions version 4.*

We could also include couple of lines about publishing the migrated changes to Azure

johnsimons
johnsimons requested changes Aug 1, 2024
View reviewed changes
@TravisNickels TravisNickels self-assigned this Aug 1, 2024
@TravisNickels TravisNickels force-pushed the cloudxp-293/azure-functions-inprocess-worker-migration branch from 794a40f to 97880c9 Compare August 3, 2024 01:31
johnsimons
johnsimons approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@johnsimons johnsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good @TravisNickels :shipit:

@TravisNickels TravisNickels marked this pull request as ready for review August 9, 2024 05:10
@TravisNickels TravisNickels merged commit 5220729 into master Aug 9, 2024
4 checks passed
@TravisNickels TravisNickels deleted the cloudxp-293/azure-functions-inprocess-worker-migration branch August 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsimons johnsimons johnsimons approved these changes

@soujay soujay soujay approved these changes

Assignees

@TravisNickels TravisNickels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TravisNickels @soujay @johnsimons