Merge branch 'dev'

CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## [v2.26.3](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v2.26.3) (2023/04/05)
+
+[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.26.2...v2.26.3)
+
+<!-- Release notes generated using configuration in .github/release.yml at dev -->
+
+## What's Changed
+### Fixed Bugs
+- Fix several Minion buffs not being calculated correctly [\#5894](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5894) ([Wires77](https://github.com/Wires77))
+- Fix level-up stats from appearing on tooltips [\#5891](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5891) ([Lilylicious](https://github.com/Lilylicious))
+- Fix MoM and Prevented Life loss effect interaction [\#5908](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5908) ([Edvinas-Smita](https://github.com/Edvinas-Smita))
+- Fix life loss prevention occurring on overkill damage resulting in undesired breakpoint behaviour [\#5910](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5910) ([QuickStick123](https://github.com/QuickStick123))
+- Fix Ghost Reaver and Mines Leech not working [\#5888](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5888) ([QuickStick123](https://github.com/QuickStick123))
+- Fix mod values on Betrayal uniques [\#5772](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5772) ([dshebib](https://github.com/dshebib))
+
+
 ## [v2.26.2](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v2.26.2) (2023/04/03)
 
 [Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.26.1...v2.26.2)
@@ -29,7 +45,7 @@
 [Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.25.1...v2.26.0)
 
 <!-- Release notes generated using configuration in .github/release.yml at dev -->
-
+\
 ## What's Changed
 ### 3.21 Changes
 - Add 3.21 tree [\#5799](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5799) ([Regisle](https://github.com/Regisle))

RELEASE.md

@@ -25,12 +25,7 @@ Steps:
 
 ## GGPK Data updates
 
-Updating data from the GGPK uses the PoB exporter (see CONTRIBUTING.md#exporting-ggpk-data-from-path-of-exile), followed by some manual tweaks that haven't been fixed in a script, yet.
-
-Steps:
-1. Run each script in the Exporter in order
-2. Revert the following changes similar to the linked examples:
-    - [Make sure the description of a keystone isn't removed](src/Data/LegionPassives.lua#L3911-L3915)
+Updating data from the GGPK uses the PoB exporter (see CONTRIBUTING.md#exporting-ggpk-data-from-path-of-exile).  Run each script in order, then check the differences in data to make sure nothing is missing that is expected.
 
 ## Skill tree updates
 

changelog.txt

@@ -1,3 +1,13 @@
+VERSION[2.26.3][2023/04/05]
+
+--- Fixed Bugs ---
+* Fix several Minion buffs not being calculated correctly (Wires77)
+* Fix level-up stats from appearing on tooltips (Lilylicious)
+* Fix MoM and Prevented Life loss effect interaction (Edvinas-Smita)
+* Fix life loss prevention occurring on overkill damage resulting in undesired breakpoint behaviour (QuickStick123)
+* Fix Ghost Reaver and Mines Leech not working (QuickStick123)
+* Fix mod values on Betrayal uniques (dshebib)
+
 VERSION[2.26.2][2023/04/03]
 
 * Fix mastery choices overlapping when they had multiple lines (Wires77)

spec/System/TestDefence_spec.lua

@@ -272,6 +272,49 @@ describe("TestDefence", function()
         assert.are.equals(0, poolsRemaining.Life)
         assert.are.equals(120, poolsRemaining.LifeLossLostOverTime)
         assert.are.equals(20, poolsRemaining.LifeBelowHalfLossLostOverTime)
+
+        build.skillsTab:PasteSocketGroup("\z
+        Label: 50% petrified\n\z
+        Petrified Blood 20/40 Alternate1  1\n\z
+        ")
+        build.skillsTab:ProcessSocketGroup(build.skillsTab.socketGroupList[1])
+        build.configTab.input.customMods = "\z
+        +1950 to life\n\z
+        +2960 to mana\n\z
+        +3000 to energy shield\n\z
+        100% less attributes\n\z
+        100% less mana reserved\n\z
+        +60% to all resistances\n\z
+        chaos damage does not bypass energy shield\n\z
+        mind over matter\n\z
+        eldritch battery\n\z
+        10% of lightning damage is taken from mana before life\n\z
+        chaos damage is taken from mana before life\n\z
+        When Hit during effect, 50% of Life loss from Damage taken occurs over 4 seconds instead\n\z
+        "
+        build.configTab.input.conditionUsingFlask = true
+        build.configTab:BuildModList()
+        runCallback("OnFrame")
+
+        _, takenDamages = takenHitFromTypeMaxHit("Fire")
+        poolsRemaining = build.calcsTab.calcs.reducePoolsByDamage(nil, takenDamages, build.calcsTab.calcsEnv.player)
+        assert.are.equals(0, poolsRemaining.Life)
+        assert.are.equals(0, poolsRemaining.EnergyShield)
+        assert.is.not_false(poolsRemaining.Mana > 0)
+
+        _, takenDamages = takenHitFromTypeMaxHit("Lightning")
+        poolsRemaining = build.calcsTab.calcs.reducePoolsByDamage(nil, takenDamages, build.calcsTab.calcsEnv.player)
+        assert.are.equals(0, poolsRemaining.Life)
+        assert.are.equals(0, poolsRemaining.EnergyShield)
+        assert.are.equals(0, poolsRemaining.Mana)
+
+        _, takenDamages = takenHitFromTypeMaxHit("Chaos")
+        poolsRemaining = build.calcsTab.calcs.reducePoolsByDamage(nil, takenDamages, build.calcsTab.calcsEnv.player)
+        assert.are.equals(0, poolsRemaining.Life)
+        assert.are.equals(0, poolsRemaining.EnergyShield)
+        assert.are.equals(0, poolsRemaining.Mana)
+
+        build.skillsTab.socketGroupList = {}
     end)
 
     -- fun part