Fix Advanced Item Description error popup problems #8311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't entirely happy with this solution, so I've moved the check into the keypress handling code. The check now only triggers on item paste, but is no longer a one-shot. I'm not sure I have the user-facing wording/logic correct though -- maybe the popup should say "OK to continue anyway, Cancel to abort paste"? I've stared at it too long and can't tell :-)
|
Nightblade
force-pushed
the
improve-AID-popup
branch
from
7b0d43c
to
a1058e6
Compare
LocalIdentity
approved these changes
Sep 26, 2024
LocalIdentity
merged commit f6d095a
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only shows once per session