Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build display stats to its own file #8337

Merged
merged 3 commits into from
Oct 20, 2024

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Oct 10, 2024

The main reason to do this is that it doesnt feel like this belongs where it is, its hard for new contributors to find without running a search on the files, and this has other issues that have built up over time like duplication of entries, and splitting it off like this makes it easier to implement something like #5752 in future.

There are a few other changes that could be done but I am leaving those either for future PRs or for feedback, namely

  • De-duplication of entries, specifically duplicates across multiple lists
  • Better groups (rather than using an empty element to split the group, eg adding comments etc)
  • White space alignment (to make pseudo columns) (do we want this?)
  • More verbose functions (instead of v and o use value and output)
  • Make warnFunc only return its boolean value, and store the warn string separately
  • The ability to save/load custom ones from settings (eg Custom display stats #5752)

@LocalIdentity LocalIdentity added the technical Hidden from release notes label Oct 20, 2024
@LocalIdentity LocalIdentity merged commit c1904df into PathOfBuildingCommunity:dev Oct 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Hidden from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants