Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Parse5 to 1.5.1 For Angular Universal Compatibility #579

Merged
merged 13 commits into from
May 13, 2016
Merged

Downgrade Parse5 to 1.5.1 For Angular Universal Compatibility #579

merged 13 commits into from
May 13, 2016

Conversation

Spittal
Copy link
Contributor

@Spittal Spittal commented May 11, 2016

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Updates package.json with version 1.5.1 of the parse5 package. This is needed for the Parse5DomAdapter in https://github.com/angular/angular/blob/master/modules/%40angular/platform-server/src/parse5_adapter.ts
  • What is the current behavior? (You can also link to an open issue here)
    Installs version 2 of the parse5 package, which is not compatible with Angular Universal
  • What is the new behavior (if this is a feature change)?
    Installs version 1.5.1 of the parse5 package, which is not compatible with Angular Universal
  • Other information:

@PatrickJS PatrickJS merged commit 41da9bd into PatrickJS:master May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants