fix(pat navigation): Don't check query string and hash fragments. #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting navigation markers based on URL comparison do not set the query string and hash fragments. When using hash navigation within one page, use pat-scroll to mark items as current.
|
Did you consider Ale's suggestion of making this configurable? |
|
Will do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting navigation markers based on URL comparison do not set the query string and hash fragments. When using hash navigation within one page, use pat-scroll to mark items as current.
This fixes a problem described in: euphorie/Euphorie#447 (comment)
It has the drawback that URL based detection of the current item when using navigation based on query strings or hash fragments (e.g. a table of contents) would not be possible anymore. But that might be corner cases.