Merge pull request #109 from PayGreen/develop

version
PayGreen · May 15, 2023 · 900d4a1 · 900d4a1
2 parents 0685d0e + e7e1bba
commit 900d4a1
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 12 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -1,6 +1,6 @@
 name: Test
 
-on: [push, pull_request, workflow_dispatch]
+on: [push, workflow_dispatch]
 
 jobs:
   phpunit:

diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name": "paygreen/paygreen-php",
-  "version": "1.3.10",
+  "version": "1.3.11",
   "description": "PayGreen PHP SDK",
   "type": "library",
   "license": "proprietary",

diff --git a/docs/v3/notification.md b/docs/v3/notification.md
@@ -33,7 +33,16 @@ $client->getListener('lis_0000');
 ## Update a listener
 
 ```php
-$client->updateListener('lis_0000', 'https://my-store.fr');
+/**
+* The third argument $params is optional
+ * (Authorized values : url, events, type)
+ */
+$client->updateListener('lis_0000', 'https://my-store.fr', array(
+    'events' => array(
+        'payment_order.authorized',
+        'payment_order.refused'
+    )
+));
 ```
 
 ## Delete a listener

diff --git a/lib/PaygreenSdk/Payment/V3/Client.php b/lib/PaygreenSdk/Payment/V3/Client.php
@@ -469,14 +469,19 @@ public function createListener(ListenerInterface $listener, $shopId = null)
 
     /**
      * @param string $listenerId
-     * @param string $url
+     * @param string|null $url
+     * @param array $params
      * @return ResponseInterface
      * @throws Exception
      *
      */
-    public function updateListener($listenerId, $url)
+    public function updateListener($listenerId, $url = null, $params = [])
     {
-        $request = (new ListenerRequest($this->requestFactory, $this->environment))->getUpdateRequest($listenerId, $url);
+        if ($url !== null) {
+            $params['url'] = $url;
+        }
+
+        $request = (new ListenerRequest($this->requestFactory, $this->environment))->getUpdateRequest($listenerId, $params);
         $this->setLastRequest($request);
 
         $response = $this->sendRequest($request);

diff --git a/lib/PaygreenSdk/Payment/V3/Request/Notification/ListenerRequest.php b/lib/PaygreenSdk/Payment/V3/Request/Notification/ListenerRequest.php
@@ -51,17 +51,15 @@ public function getCreateRequest(ListenerInterface $listener, $shopId = null)
 
     /**
      * @param string $listenerId
-     * @param string $url
+     * @param array $params
      *
      * @return RequestInterface
      */
-    public function getUpdateRequest($listenerId, $url)
+    public function getUpdateRequest($listenerId, $params)
     {
-        $body = ['url' => $url];
-
         return $this->requestFactory->create(
             "/notifications/listeners/{$listenerId}",
-            (new Serializer([new CleanEmptyValueNormalizer()], [new JsonEncoder()]))->serialize($body, 'json')
+            (new Serializer([new CleanEmptyValueNormalizer()], [new JsonEncoder()]))->serialize($params, 'json')
         )->withAuthorization()->isJson()->getRequest();
     }
 

diff --git a/tests/Unit/Payment/V3/ClientTest.php b/tests/Unit/Payment/V3/ClientTest.php
@@ -438,14 +438,21 @@ public function testRequestCreateListener()
 
     public function testRequestUpdateListener()
     {
-        $this->client->updateListener('lis_12345', 'https://my-listener-url.fr');
+        $this->client->updateListener(
+            'lis_12345',
+            'https://my-listener-url.fr',
+            array(
+                'events' => array('payment_order.authorized', 'payment_order.successed')
+            )
+        );
         $request = $this->client->getLastRequest();
 
         $content = json_decode($request->getBody()->getContents());
 
         $this->assertEquals('POST', $request->getMethod());
         $this->assertEquals('/notifications/listeners/lis_12345', $request->getUri()->getPath());
         $this->assertEquals('https://my-listener-url.fr', $content->url);
+        $this->assertEquals(array('payment_order.authorized', 'payment_order.successed'), $content->events);
     }
 
     public function testRequestGetListener()