unset not releveant actions in direct\offsite factories.

Payum · Nov 27, 2015 · b316410 · b316410
1 parent 2e7595d
commit b316410
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 0 deletions.
diff --git a/src/OmnipayDirectGatewayFactory.php b/src/OmnipayDirectGatewayFactory.php
@@ -1,9 +1,19 @@
 <?php
 namespace Payum\OmnipayBridge;
+use Payum\Core\Bridge\Spl\ArrayObject;
 
 /**
  * @deprecated since 1.0.0-BETA1
  */
 class OmnipayDirectGatewayFactory extends OmnipayGatewayFactory
 {
+    /**
+     * {@inheritDoc}
+     */
+    protected function populateConfig(ArrayObject $config)
+    {
+        parent::populateConfig($config);
+
+        unset($config['payum.action.capture_offsite']);
+    }
 }
diff --git a/src/OmnipayOffsiteGatewayFactory.php b/src/OmnipayOffsiteGatewayFactory.php
@@ -1,9 +1,19 @@
 <?php
 namespace Payum\OmnipayBridge;
+use Payum\Core\Bridge\Spl\ArrayObject;
 
 /**
  * @deprecated since 1.0.0-BETA1
  */
 class OmnipayOffsiteGatewayFactory extends OmnipayGatewayFactory
 {
+    /**
+     * {@inheritDoc}
+     */
+    protected function populateConfig(ArrayObject $config)
+    {
+        parent::populateConfig($config);
+
+        unset($config['payum.action.capture']);
+    }
 }
diff --git a/tests/OmnipayDirectGatewayFactoryTest.php b/tests/OmnipayDirectGatewayFactoryTest.php
@@ -79,6 +79,21 @@ public function shouldAllowCreateGatewayConfig()
         $this->assertNotEmpty($config);
     }
 
+    /**
+     * @test
+     */
+    public function shouldContainCaptureActionAndMissCaptureOffsiteAction()
+    {
+        $factory = new OmnipayDirectGatewayFactory();
+
+        $config = $factory->createConfig(['type' => 'Dummy']);
+
+        $this->assertInternalType('array', $config);
+
+        $this->assertArrayHasKey('payum.action.capture', $config);
+        $this->assertArrayNotHasKey('payum.action.capture_offsite', $config);
+    }
+
     /**
      * @test
      *

diff --git a/tests/OmnipayOffsiteGatewayFactoryTest.php b/tests/OmnipayOffsiteGatewayFactoryTest.php
@@ -91,6 +91,21 @@ public function shouldAllowCreateGatewayConfig()
         $this->assertNotEmpty($config);
     }
 
+    /**
+     * @test
+     */
+    public function shouldContainCaptureOffsiteActionAndMissCaptureAction()
+    {
+        $factory = new OmnipayOffsiteGatewayFactory();
+
+        $config = $factory->createConfig(['type' => 'Dummy']);
+
+        $this->assertInternalType('array', $config);
+
+        $this->assertArrayHasKey('payum.action.capture_offsite', $config);
+        $this->assertArrayNotHasKey('payum.action.capture', $config);
+    }
+
     /**
      * @test
      *