Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record commit at package installation #3390

Merged
merged 14 commits into from
Nov 2, 2024
Merged

Record commit at package installation #3390

merged 14 commits into from
Nov 2, 2024

Commits on Oct 2, 2024

  1. add record of Git commit at package build time

    @infotroph
    infotroph committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ce05505 View commit details
    Browse the repository at this point in the history

  2. more compact indicator of modified tree

    @infotroph
    infotroph committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8fb2061 View commit details
    Browse the repository at this point in the history

  3. include hash in version report (including nicer print nethod)

    @infotroph
    infotroph committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6e771f9 View commit details
    Browse the repository at this point in the history

  4. update tests for new column

    @infotroph
    infotroph committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1d202ce View commit details
    Browse the repository at this point in the history

  5. avoid unintended data

    @infotroph
    infotroph committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fb7ec70 View commit details
    Browse the repository at this point in the history

  6. speedups 

    On my machine this drops from ~3-4 sec for first call and ~2 after,
to ~2 sec for first call and ~1 after.
No longer feels "too slow" to me.
    @infotroph
    infotroph committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8248461 View commit details
    Browse the repository at this point in the history

  7. set env inside R call 

    Probably not a big difference, but felt to me like it make the Make output a little easier to interpret
    @infotroph
    infotroph committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    059a93d View commit details
    Browse the repository at this point in the history

  8. more printing tweaks 

    - use args provided at print time
- default to no rownames and left alignment
- truncate more
    @infotroph
    infotroph committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f78fd1f View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. one less letter

    @infotroph
    infotroph committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    26515c9 View commit details
    Browse the repository at this point in the history

  2. tests

    @infotroph
    infotroph committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    769e9e3 View commit details
    Browse the repository at this point in the history

  3. changelog

    @infotroph
    infotroph committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5984931 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. document that version is read from env at install not build 

    It would be conceptually better to record it at build time, but R code is not parsed at that stage.
If we really want build-time recording, could consider saving it as data (data/*.R are run at build time)
    @infotroph
    infotroph committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5a3faca View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. only display hash for dev versions

    @infotroph
    infotroph committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    83af3ed View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Merge branch 'develop' into memoize-commit-at-build-time

    @infotroph
    infotroph authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    edd24b0 View commit details
    Browse the repository at this point in the history