Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SCORE/SCRUB and BASIL #253

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 4, 2023

Closes None.

Changes proposed in this pull request

  • Clean up ScoreAndScrubCBF.
  • Rename inputs and outputs of ScoreAndScrubCBF and BASILCBF.
  • Move ComputeCBFQC and ComputeCBFQCforGE from cbf_computation to new qc module.
  • Replace use_default (typo) with usedefault.
  • Refactor _score_cbf, _tune.

To do:

  • Refactor _robust_fit
  • Refactor _scrub_cbf
  • Replace _getchisquare with a scipy.stats call.

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Apr 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (247515a) 79.62% compared to head (a8e0c07) 80.30%.

Files Patch % Lines
aslprep/interfaces/cbf.py 81.48% 4 Missing and 1 partial ⚠️
aslprep/utils/cbf.py 94.28% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   79.62%   80.30%   +0.67%     
==========================================
  Files          37       37              
  Lines        3946     3904      -42     
  Branches      551      538      -13     
==========================================
- Hits         3142     3135       -7     
+ Misses        625      604      -21     
+ Partials      179      165      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants