Apply notch filter appropriate number of times based on --motion-filter-order
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cindyhfls would you mind reviewing my changes? Also, given that you detected the problem and proposed the fix, would you like me to add you to our CITATION.cff file? If so, can you provide your information to match this? Lines 13 to 17 in 16b16f7 |
Not sure why this wasn't a problem before now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
+ Coverage 78.89% 78.90% +0.01%
==========================================
Files 59 59
Lines 7376 7381 +5
Branches 956 956
==========================================
+ Hits 5819 5824 +5
Misses 1266 1266
Partials 291 291 ☔ View full report in Codecov by Sentry. |
|
@cindyhfls I'm going to merge this now. If you find a problem feel free to open a new issue, and if you'd like to be added to our CITATION.cff please open a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1272 and closes #1278. Thanks to @cindyhfls for detecting the problem and figuring out the solution.
Changes proposed in this pull request
--motion-filter-orderparameter by 4 instead of 2 when using the "notch" motion filter, asiirnotchis a second-order filter andfiltfiltapplies the filter both forwards and backwards (equaling 4 total applications).