-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallelize gpu test #1042
base: master
Are you sure you want to change the base?
parallelize gpu test #1042
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 98.10% 90.08% -8.02%
==========================================
Files 233 112 -121
Lines 39079 16990 -22089
==========================================
- Hits 38339 15306 -23033
- Misses 740 1684 +944 ☔ View full report in Codecov by Sentry. |
@@ -206,7 +206,8 @@ jobs: | |||
OMP_PROC_BIND: false | |||
run: | | |||
DEVICENAME=`echo ${{ matrix.pl_backend }} | sed "s/_/./g"` | |||
PL_DEVICE=${DEVICENAME} python -m pytest tests/ $COVERAGE_FLAGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @josephleekl . Do we want to install pytest-xdist
? How can we confiugre the maping between cpu cores and gpu devices or instances (MIG)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note here: benchmarks are required for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! pytest-xdist
is already installed from requirements-dev.txt
. We're just using the single GPU device, but might be possible that if we partition into MIG and map directly, it will be more performant.
I have posted some preliminary timings in the PR description; for now GPU tests seem to take longer... I'll investigate more when I have time!
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Some quick test result:
Python Tests (lightning_kokkos, kokkos-4.5.00, model-CUDA)
24m22s -> 17m35s
Python Tests (lightning_gpu, cuda-12)
1h21m29s -> 2h12m34s
Python Tests (lightning_tensor, cuda-12)
36m15s -> 24m2s
Benefits:
Possible Drawbacks:
Related GitHub Issues: