Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dyn-alloc-lk] Lightning Kokkos support dynamic qubit allocation #1049

Merged
merged 49 commits into from
Feb 6, 2025

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 24, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
This PR adds support for dynamic allocation for LK, and merges into [dyn-alloc-base], which contains the update for dynamic allocation for lightning.qubit.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-82704]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@josephleekl josephleekl changed the title Lightning Kokkos support dynamic qubit allocation [dyn-alloc-lk] Lightning Kokkos support dynamic qubit allocation Jan 24, 2025
@josephleekl josephleekl marked this pull request as ready for review January 24, 2025 19:09
@josephleekl josephleekl added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 2.94118% with 33 lines in your changes missing coverage. Please review.

Project coverage is 27.55%. Comparing base (e217dc3) to head (26f0222).
Report is 4 commits behind head on dyn-alloc.

Files with missing lines Patch % Lines
pennylane_lightning/lightning_gpu/lightning_gpu.py 0.00% 18 Missing ⚠️
...ane_lightning/lightning_kokkos/lightning_kokkos.py 0.00% 8 Missing ⚠️
...ane_lightning/lightning_tensor/lightning_tensor.py 12.50% 7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e217dc3) and HEAD (26f0222). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (e217dc3) HEAD (26f0222)
7 4
Additional details and impacted files
@@              Coverage Diff               @@
##           dyn-alloc    #1049       +/-   ##
==============================================
- Coverage      94.43%   27.55%   -66.88%     
==============================================
  Files            178       29      -149     
  Lines          27562     2649    -24913     
==============================================
- Hits           26028      730    -25298     
- Misses          1534     1919      +385     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl removed the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 27, 2025
@josephleekl josephleekl marked this pull request as draft January 31, 2025 19:43
@josephleekl josephleekl added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 31, 2025
@josephleekl josephleekl marked this pull request as ready for review January 31, 2025 20:22
josephleekl and others added 14 commits January 31, 2025 20:22
)

### Before submitting

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**
This PR adds support for dynamic allocation for LG and LT, and merges
into [dyn-alloc-lk], which contains the update for dynamic allocation
for lightning.kokkos.

LGPU + MPI is not supported right now.

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

[sc-82704]
@josephleekl josephleekl merged commit 3f58f4f into dyn-alloc Feb 6, 2025
39 of 40 checks passed
@josephleekl josephleekl deleted the dyn-alloc-lk branch February 6, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-gpu-runner Enable usage of GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants