-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dyn-alloc-lk] Lightning Kokkos support dynamic qubit allocation #1049
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dyn-alloc #1049 +/- ##
==============================================
- Coverage 94.43% 27.55% -66.88%
==============================================
Files 178 29 -149
Lines 27562 2649 -24913
==============================================
- Hits 26028 730 -25298
- Misses 1534 1919 +385 ☔ View full report in Codecov by Sentry. |
) ### Before submitting Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [ ] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** This PR adds support for dynamic allocation for LG and LT, and merges into [dyn-alloc-lk], which contains the update for dynamic allocation for lightning.kokkos. LGPU + MPI is not supported right now. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-82704]
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This PR adds support for dynamic allocation for LK, and merges into [dyn-alloc-base], which contains the update for dynamic allocation for lightning.qubit.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-82704]