Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dyn-alloc-lt] Lightning Tensor support dynamic qubit allocation #1060

Merged
merged 10 commits into from
Feb 3, 2025

Conversation

josephleekl
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.65%. Comparing base (fc1e284) to head (6702c76).
Report is 1 commits behind head on dyn-alloc-lg.

Files with missing lines Patch % Lines
...ane_lightning/lightning_tensor/lightning_tensor.py 14.28% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fc1e284) and HEAD (6702c76). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fc1e284) HEAD (6702c76)
6 5
Additional details and impacted files
@@                Coverage Diff                @@
##           dyn-alloc-lg    #1060       +/-   ##
=================================================
- Coverage         92.61%   53.65%   -38.96%     
=================================================
  Files               112       29       -83     
  Lines             17067     2641    -14426     
=================================================
- Hits              15806     1417    -14389     
+ Misses             1261     1224       -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl marked this pull request as ready for review January 31, 2025 20:29
@josephleekl josephleekl merged commit db7039d into dyn-alloc-lg Feb 3, 2025
65 of 67 checks passed
@josephleekl josephleekl deleted the dyn-alloc-lt branch February 3, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant