Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image build not supported for Apple Silicon Chip and small minor bugs. #6452

Open
zazabap opened this issue Oct 26, 2024 · 1 comment
Labels
enhancement ✨ New feature or request

Comments

@zazabap
Copy link
Contributor

zazabap commented Oct 26, 2024

Feature details

Recently during development, I tried using docker image build process written in the https://docs.pennylane.ai/en/stable/development/guide/installation.html?highlight=docker with Apple M2 chip.

However, there are issues encountered while preparing for metadata
issue
I consider adding one line of code should solve such issue.
Also in line :

RUN python3 setup.py install

This gives error that setuptools are not included, maybe we could include it in the requirements.txt? There are also many minor issues like dependencies not found, missing libraries in building and etc.

The python3.12 in default installation should not suitable for development or docker file creation. Maybe the python3.10 stable version is the best for dockerfile creation? Or it would be better just upload the proper docker images?

Implementation

Modify these two files adding necessary packages could solve the build problem.

docker/pennylane.dockerifle
requirements.txt

If possible, I could contribute modifying the docker works with python3.10 and M2 chip.

How important would you say this feature is?

1: Not important. Would be nice to have.

Additional information

No response

@zazabap zazabap added the enhancement ✨ New feature or request label Oct 26, 2024
@albi3ro
Copy link
Contributor

albi3ro commented Oct 28, 2024

Thanks for opening this issue @zazabap .

We do currently have docker builds actively maintained, unfortunately they are not the ones mentioned in the installation guide.

The builds can be found at:

https://hub.docker.com/r/pennylaneai/pennylane/tags

and information can be found at:

https://docs.pennylane.ai/projects/lightning/en/stable/dev/docker.html

The ones discussed in the installation guide have never been really tested or maintained, and we just haven't gotten around to getting rid of them. We will try to reprioritize fully removing them.

justinpickering added a commit that referenced this issue Oct 30, 2024
**Context:**
See [slack
message](https://xanaduhq.slack.com/archives/C0743CNS9E3/p1730125288115899)
regarding [GH
issue](#6452).

- Docker description in [Installation and dependencies
documentation](https://docs.pennylane.ai/en/stable/development/guide/installation.html?highlight=docker)is
outdated due to unmaintained Docker builds. We recommend removing the
Docker section entirely, and guiding users to [Docker support in
Lightning
documentation](https://docs.pennylane.ai/projects/lightning/en/stable/dev/docker.html).

**Description of the Change:**
- Remove outdated 'Docker' section in [Installation and dependencies
documentation](https://docs.pennylane.ai/en/stable/development/guide/installation.html?highlight=docker)

**Benefits:**
- Eliminates outdated information, helping prevent user confusion from
unsupported Docker builds as noted in this [GH
issue](#6452).

**Possible Drawbacks:**

**Related GitHub Issues:**
#6452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants