Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated Docker description from Installation docs #6487

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

justinpickering
Copy link
Contributor

@justinpickering justinpickering commented Oct 30, 2024

Context:
See slack message regarding GH issue.

Description of the Change:

Benefits:

  • Eliminates outdated information, helping prevent user confusion from unsupported Docker builds as noted in this GH issue.

Possible Drawbacks:

Related GitHub Issues:
#6452

@justinpickering justinpickering marked this pull request as ready for review October 30, 2024 16:43
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@justinpickering
Copy link
Contributor Author

[sc-76898]

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justinpickering

No issue from me. Do we want the changes for the new README to go into master or the 0.39 release for the other PR?

Also, I think the linked related PR is the wrong index value.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v0.39.0-docs@7bbfebb). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             v0.39.0-docs    #6487   +/-   ##
===============================================
  Coverage                ?   99.38%           
===============================================
  Files                   ?      452           
  Lines                   ?    42797           
  Branches                ?        0           
===============================================
  Hits                    ?    42535           
  Misses                  ?      262           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinpickering
Copy link
Contributor Author

Thanks @mlxd !

No issue from me. Do we want the changes for the new README to go into master or the 0.39 release for the other PR?

The README changes (PR) aren’t specific to the 0.39 release, so I think it can continue pointing to master unless there’s a particular reason to change it.

Also, I think the linked related PR is the wrong index value.

Fixed! Pointing to #6452 instead :)

@mudit2812 mudit2812 added this to the v0.39 milestone Oct 30, 2024
@justinpickering justinpickering merged commit d86a964 into v0.39.0-docs Oct 30, 2024
49 checks passed
@justinpickering justinpickering deleted the update-docker-docs branch October 30, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants